Make GPIOs start in a Disconnected state#220
Merged
jamesmunns merged 2 commits intonrf-rs:masterfrom Sep 12, 2020
jonas-schievink:pin-reset-disconnected
Merged
Make GPIOs start in a Disconnected state#220jamesmunns merged 2 commits intonrf-rs:masterfrom jonas-schievink:pin-reset-disconnected
Disconnected state#220jamesmunns merged 2 commits intonrf-rs:masterfrom
jonas-schievink:pin-reset-disconnected
Conversation
jamesmunns
approved these changes
Sep 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #213 by making all GPIO pins start in a new
Disconnectedstate that does not implement any of the embedded-hal traits and needs to be converted to a functional state first.I've also implemented
Channel<Saadc>for all GPIO type states (even output states), which should be correct according to the GPIO schematics in the manual. Using a pin as a SAADC channel will fully switch the pin from the GPIO circuitry to the analog circuitry. This avoids breaking code that passes an uninitialized pin to the SAADC.