Add check for I2S buffer pointer alignment#225
Merged
jonas-schievink merged 5 commits intonrf-rs:masterfrom Sep 18, 2020
Merged
Add check for I2S buffer pointer alignment#225jonas-schievink merged 5 commits intonrf-rs:masterfrom
jonas-schievink merged 5 commits intonrf-rs:masterfrom
Conversation
Contributor
thalesfragoso
left a comment
thalesfragoso
left a comment
There was a problem hiding this comment.
Thanks again for this PR, I left some suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer pointer addresses need to be 4 byte aligned to be used with the I2S DMA.
This PR adds a check in the
rx,transferandtxTransferconstructors and returns anError::BufferMisalignedif this is not fulfilled.Added trait bounds for supported word sizes (<=4 byte words)
Controller and peripheral demos were updated to utilize
Alignedto ensure correct alignment.Tested and verified to be working correctly on hardware.