Add SPIS module#226
Merged
jamesmunns merged 9 commits intonrf-rs:masterfrom Sep 22, 2020
Merged
Conversation
jamesmunns
reviewed
Sep 22, 2020
Member
jamesmunns
left a comment
jamesmunns
left a comment
There was a problem hiding this comment.
Overall looks good, I'll plan on using this pretty much immediately!
I did have a couple nits, but nothing huge :)
jamesmunns
requested changes
Sep 22, 2020
Member
|
Also, could you please add this to the changelog? |
Contributor
Author
Thanks for your comments, agreed and fixed :) |
jamesmunns
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a module for the SPIS peripheral, using the
embedded-dmatraits.Tested on nRF52840.
Demo of usage (pinout is for the ItsyBitsy nRF52840):
https://github.com/kalkyl/nrf-hal/blob/spis/examples/spis-demo/src/main.rs