gpio: change Input<Disconnected> to Disconnected.#245
Merged
jonas-schievink merged 1 commit intonrf-rs:masterfrom Oct 6, 2020
Merged
gpio: change Input<Disconnected> to Disconnected.#245jonas-schievink merged 1 commit intonrf-rs:masterfrom
Input<Disconnected> to Disconnected.#245jonas-schievink merged 1 commit intonrf-rs:masterfrom
Conversation
jonas-schievink
approved these changes
Oct 6, 2020
Contributor
jonas-schievink
left a comment
There was a problem hiding this comment.
Thanks! I thought you'd have to change more than that, neat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the default Pin state from
Pin<Input<Disconnected>>toPin<Disconnected>.This is desirable because it makes
is_high,is_lownot available inDisconnectedstate, since they don't actually work. Nordic docs state this:I will add an
into_disconnectedfunction in a future PR, since it's desirable to disconnect input pins when not in use to save power.