Remove Started/Stopped type state from Rtc#252
Merged
jonas-schievink merged 2 commits intonrf-rs:masterfrom Oct 26, 2020
Merged
Remove Started/Stopped type state from Rtc#252jonas-schievink merged 2 commits intonrf-rs:masterfrom
Started/Stopped type state from Rtc#252jonas-schievink merged 2 commits intonrf-rs:masterfrom
Conversation
This made it really difficult to enable and disable the RTC on demand with RTIC. Pass the prescaler as argument to the costructor.
Contributor
jonas-schievink
left a comment
jonas-schievink
left a comment
There was a problem hiding this comment.
Thanks, this looks reasonable!
This does mean that you can't change the prescaler after creating the RTC though. I don't think that's a common thing to do, so it should be fine, but we might want to add a fn free(self) -> RTC to enable that use case again.
Contributor
|
Oh, it already has a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type states make it difficult to enable and disable the RTC on demand with RTIC.
Started/Stoppedtypes were only used to restrict the usage ofset_prescaler()to a disabled RTC.Pass the prescaler as argument to the costructor instead.