Fix EasyDMA max size.#315
Merged
bors[bot] merged 1 commit intonrf-rs:masterfrom May 11, 2021
Merged
Conversation
Dirbaio
force-pushed
the
fix-easydma-max-size
branch
from
fccbc95 to
47bb76b
Compare
EASY_DMA_SIZE changes based on peripheral, but it is always equal for UARTE, SPIx, TWIx, so I've kept a single variable. Data source is nrfx files, like [this one](https://github.com/NordicSemiconductor/nrfx/blob/b5399066bd7f3dc32ee15510d06ef7137bcacf36/mdk/nrf9160_peripherals.h#L150). Fixes nrf-rs#314
Dirbaio
force-pushed
the
fix-easydma-max-size
branch
from
47bb76b to
35282f8
Compare
jonas-schievink
approved these changes
May 11, 2021
Contributor
jonas-schievink
left a comment
jonas-schievink
left a comment
There was a problem hiding this comment.
why on earth are these all over the place...
thanks for fixing this!
bors r+
| pub const SRAM_UPPER: usize = 0x3000_0000; | ||
|
|
||
| #[cfg(any(feature = "51", feature = "52810", feature = "52832"))] | ||
| pub const FORCE_COPY_BUFFER_SIZE: usize = 255; |
Contributor
There was a problem hiding this comment.
Do we even need this constant if we already have EASY_DMA_SIZE?
Contributor
There was a problem hiding this comment.
I would say it's not necessarily bad to have a smaller force copy buffer size than the maximum allowed by DMA, because it gives less side effects with too big buffers overflowing memory unintentionally.
Member
Author
There was a problem hiding this comment.
Yeah, stack-allocating a 64kb copy buffer wouldn't be pretty
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EASY_DMA_SIZE changes based on peripheral, but it is always equal for UARTE, SPIx, TWIx, so
I've kept a single variable.
Data source is nrfx files, like this one.
I've added the values for all nrf chips, even currently unsupported ones, because they'll likely be supported soon. Can remove it if that's not wanted.
Fixes #314