Uart example#317
Conversation
There was a problem hiding this comment.
@jonathanpallant Can you elaborate further on the changes re 1ba3630 and why they are necessary? I was expecting to implement the nrfx workaround when initialising the UART for the 53 and 91 boards (see description), not a change for all boards. Thanks.
I've just seen #319. I shall revert your commit here @jonathanpallant and turn this PR into simply providing an example of using UART for nrf-hal. Thanks. |
|
@jonathanpallant Reverted your commit given the UART improvements/fixes elsewhere and made this just an example of how to set the UART up. |
Provides a simple UART example so that we can test out UART on the nRF52840 and nRF9160
|
No more changes expected here. Please review/merge accordingly. |
thejpster
left a comment
There was a problem hiding this comment.
I think we should remove embed.toml, and add 9160 to the xtask list, but otherwise looks OK.
I provided the
I will do this shortly. Thanks. |
|
The 9160 for the hello world example is now included in the xtask. |
Oh! I totally didn't spot they'd been added to all the other examples. Yes, of course, we should be consistent. |
|
bors r+ |
|
Build succeeded: |
Provides the simplest example of using UART for both the 52840 and 9160.
Tested successfully on: