Add From impl for pins#364
Merged
Conversation
Author
|
I think the build error is unrelated to my change since that's a dependency resolution issue and my code just adds a |
Merged
Contributor
|
Thanks! The CI issue should have been fixed by #365. bors r+ |
Author
|
Awesome! Would you be able to cut a release after this? I can always pin to git but I've been trying to cut down on the amount of git dependencies in my |
Contributor
|
Build succeeded: |
Contributor
|
Sadly releases are pretty involved, so I'd like to get some more changes in before I publish one |
Author
|
Understandable! I can pin to git for now. Thanks for merging so fast! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this when needing to take a generic struct that could contain any gpio pin. Since all the gpio pins have a degrade function I see no reason to not implement
From. This allows generic code to work better.