Nrf5340 netcore#386
Conversation
|
Hey, would love to see this merged. @Sandraak is an intern with us at Tweede golf and she's been working on this under my guidance. She has also tested some of the peripherals to check if everything is working alright and it did. I think it's good enough to be merged as it is right now. |
|
Taking a look 👀 |
jonas-schievink
left a comment
There was a problem hiding this comment.
Please format the code with cargo fmt and add the new crate to xtask/src/lib.rs
|
Thanks for the feedback @jonas-schievink ! |
| "Jonathan Pallant (42 Technology) <jonathan.pallant@42technology.com>", | ||
| "Sascha Wise <me@saschawise.com", |
There was a problem hiding this comment.
Authors list doesn't look correct. You can either list yourself there, or remove the authors field, since it's optional.
|
It looks like your commit email isn't set to one that GitHub recognizes. If you want your contribution to be attributed correctly, consider adding your commit email to your GitHub profile. |
|
bors r+ |
|
Build succeeded: |
Added support for the nrf5340-netcore. This support consists mostly of cfg annotations and some very small adjustments.