Skip to content

Nrf5340 netcore#386

Merged
bors[bot] merged 7 commits intonrf-rs:masterfrom
Sandraak:nrf5340-netcore
May 31, 2022
Merged

Nrf5340 netcore#386
bors[bot] merged 7 commits intonrf-rs:masterfrom
Sandraak:nrf5340-netcore

Conversation

@Sandraak
Copy link
Copy Markdown
Contributor

Added support for the nrf5340-netcore. This support consists mostly of cfg annotations and some very small adjustments.

@diondokter
Copy link
Copy Markdown
Contributor

Hey, would love to see this merged. @Sandraak is an intern with us at Tweede golf and she's been working on this under my guidance. She has also tested some of the peripherals to check if everything is working alright and it did.

I think it's good enough to be merged as it is right now.

@jonas-schievink
Copy link
Copy Markdown
Contributor

Taking a look 👀

Copy link
Copy Markdown
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the code with cargo fmt and add the new crate to xtask/src/lib.rs

Comment thread nrf-hal-common/src/uicr.rs Outdated
Comment thread nrf-hal-common/src/uicr.rs Outdated
Comment thread nrf5340-net-hal/README.md Outdated
Comment thread .gitignore
@Sandraak
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback @jonas-schievink !

Comment thread nrf5340-net-hal/Cargo.toml Outdated
Comment thread nrf5340-net-hal/Cargo.toml Outdated
Comment on lines +9 to +10
"Jonathan Pallant (42 Technology) <jonathan.pallant@42technology.com>",
"Sascha Wise <me@saschawise.com",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authors list doesn't look correct. You can either list yourself there, or remove the authors field, since it's optional.

@jonas-schievink
Copy link
Copy Markdown
Contributor

It looks like your commit email isn't set to one that GitHub recognizes. If you want your contribution to be attributed correctly, consider adding your commit email to your GitHub profile.

Comment thread CHANGELOG.md Outdated
@jonas-schievink
Copy link
Copy Markdown
Contributor

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented May 31, 2022

Build succeeded:

@bors bors Bot merged commit 56e2752 into nrf-rs:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants