Skip to content

chore(core): support node 24#31934

Merged
jaysoo merged 7 commits intomasterfrom
feat/support-node-24
Sep 4, 2025
Merged

chore(core): support node 24#31934
jaysoo merged 7 commits intomasterfrom
feat/support-node-24

Conversation

@ndcunningham
Copy link
Copy Markdown
Contributor

@ndcunningham ndcunningham commented Jul 15, 2025

Changes

  • Fix builtin module test to avoid duplicate node: prefixes

Testing

  • Update ci pipeline to use node v24
  • Update agents to use node v24

MISC

Requires: #32223

@ndcunningham ndcunningham self-assigned this Jul 15, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Sep 3, 2025 8:43pm

@ndcunningham ndcunningham changed the title chore(core): run nightlies to see e2e failures for node 24 chore(core): support node 24 Jul 15, 2025
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jul 15, 2025

View your CI Pipeline Execution ↗ for commit 56f5117

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 17m 50s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 9s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 7s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 7s View ↗
nx documentation ✅ Succeeded 1m 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-03 20:55:45 UTC

@ndcunningham ndcunningham force-pushed the feat/support-node-24 branch from 569a97d to d5e2be2 Compare July 28, 2025 16:08
@ndcunningham ndcunningham force-pushed the feat/support-node-24 branch from 44ddc50 to 75efeb4 Compare July 29, 2025 18:13
@ndcunningham ndcunningham force-pushed the feat/support-node-24 branch 3 times, most recently from f986e66 to 9a45d15 Compare July 29, 2025 19:35
@ndcunningham ndcunningham force-pushed the feat/support-node-24 branch from 9a45d15 to a22b147 Compare July 29, 2025 20:12
@ndcunningham ndcunningham force-pushed the feat/support-node-24 branch from a22b147 to 28a8c41 Compare July 29, 2025 20:33
@ndcunningham ndcunningham force-pushed the feat/support-node-24 branch 2 times, most recently from dd8619f to b88a70b Compare July 29, 2025 21:32
@ndcunningham ndcunningham force-pushed the feat/support-node-24 branch 2 times, most recently from 5c25063 to 9021325 Compare July 30, 2025 15:41
@ndcunningham ndcunningham force-pushed the feat/support-node-24 branch 3 times, most recently from 769664f to 9ae2fc1 Compare July 30, 2025 17:33
@ndcunningham ndcunningham marked this pull request as ready for review July 30, 2025 17:34
@ndcunningham ndcunningham requested review from a team and FrozenPandaz as code owners July 30, 2025 17:34
- Add set-node-options.js helper script for version-specific NODE_OPTIONS
- Apply --no-experimental-strip-types flag only for Node.js 24+
- Fix Jest 30 + Node.js 24 TypeScript config parsing issue
- Fix builtin module test to avoid duplicate node: prefixes
Comment thread e2e/release/src/custom-registries.test.ts
Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

We've updated the gradle wrapper execution approach to fix classpath and execution issues. The changes modify both gradlew scripts to use -jar execution instead of classpath-based execution, which should resolve gradle wrapper startup problems. The gradle-wrapper.jar binary was also updated as part of this fix.

We verified this fix by re-running e2e-release:e2e-ci--src/custom-registries.test.ts.

Suggested Fix changes
diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar
index 9bbc975..1b33c55 100644
Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ
diff --git a/gradlew b/gradlew
index faf9300..23d15a9 100755
--- a/gradlew
+++ b/gradlew
@@ -114,7 +114,7 @@ case "$( uname )" in                #(
   NONSTOP* )        nonstop=true ;;
 esac
 
-CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
+CLASSPATH="\\\"\\\""
 
 
 # Determine the Java command to use to start the JVM.
@@ -213,7 +213,7 @@ DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
 set -- \
         "-Dorg.gradle.appname=$APP_BASE_NAME" \
         -classpath "$CLASSPATH" \
-        org.gradle.wrapper.GradleWrapperMain \
+        -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \
         "$@"
 
 # Stop when "xargs" is not available.
diff --git a/gradlew.bat b/gradlew.bat
index 9d21a21..db3a6ac 100644
--- a/gradlew.bat
+++ b/gradlew.bat
@@ -70,11  70,11 @@ goto fail
 :execute
 @rem Setup the command line
 
-set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
+set CLASSPATH=
 
 
 @rem Execute Gradle
-"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %*
+"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %*
 
 :end
 @rem End local scope for the variables with windows NT shell

Apply fix via Nx Cloud  Reject fix via Nx Cloud  Nx CloudView interactive diff and more actions ↗


⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.

Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

We restored the corrupted Gradle wrapper files (gradlew, gradlew.bat, and gradle-wrapper.jar) that were causing the e2e test timeout. The corrupted CLASSPATH configuration in the wrapper scripts was preventing the verdaccio setup from completing, leading to the 10-minute timeout in the custom-registries test.

We could not verify this fix.

No changes to commit - the issue was resolved by restoring corrupted Gradle wrapper files to their proper state using `git restore`.

Apply fix via Nx Cloud  Reject fix via Nx Cloud  Nx CloudView interactive diff and more actions ↗


⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants