Skip to content

fix(core): hide already-installed nx packages from suggestion list during nx import#34227

Merged
MaxKless merged 1 commit intomasterfrom
fix-already-installed-plugins-import
Jan 27, 2026
Merged

fix(core): hide already-installed nx packages from suggestion list during nx import#34227
MaxKless merged 1 commit intomasterfrom
fix-already-installed-plugins-import

Conversation

@MaxKless
Copy link
Copy Markdown
Contributor

@MaxKless MaxKless commented Jan 27, 2026

Current Behavior

If something is in package.json#dependencies, we still suggest it to be nx add-ed during nx import

Expected Behavior

If a plugin is already installed, we don't suggest it anymore

@MaxKless MaxKless requested a review from a team as a code owner January 27, 2026 14:43
@MaxKless MaxKless requested a review from FrozenPandaz January 27, 2026 14:43
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Jan 27, 2026 2:49pm

Request Review

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 27, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 110c234
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/6978cf033e45f100089e13a8
😎 Deploy Preview https://deploy-preview-34227--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jan 27, 2026

View your CI Pipeline Execution ↗ for commit 110c234

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 8m 39s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 1m 52s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 7s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-27 16:51:44 UTC

@MaxKless MaxKless enabled auto-merge (squash) January 27, 2026 16:48
@MaxKless MaxKless merged commit f89ccb0 into master Jan 27, 2026
23 of 25 checks passed
@MaxKless MaxKless deleted the fix-already-installed-plugins-import branch January 27, 2026 18:23
FrozenPandaz pushed a commit that referenced this pull request Jan 29, 2026
…ring nx import (#34227)

## Current Behavior
If something is in `package.json#dependencies`, we still suggest it to
be `nx add`-ed during `nx import`

## Expected Behavior
If a plugin is already installed, we don't suggest it anymore

(cherry picked from commit f89ccb0)
Copy link
Copy Markdown

@JacobMccaakill JacobMccaakill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    • @

@JacobMccaakill
Copy link
Copy Markdown

    • @

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants