Add negative-path validation coverage#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The suite only tested acceptance, so a target that is too lenient (accepts malformed expressions, mis-accounts sizes, skips structural validation) still scored well. This adds the matching rejection coverage:
begins_withoperand types,contains()duplicate operands, redundant parentheses,size()UTF-16 counting, number byte-sizing,ExclusiveStartKeyandSegmentvalidation, and a small control-plane sweep. Error codes sit in the operation's own tier, exact messages in tier3.Tests drafted with AI assistance (Claude Opus 4.7), characterised and validated against real AWS DynamoDB.
Closes #16.
Checklist
Tier and scope
No tier definitions or pipeline changes. When the results table is regenerated, lenient targets gain fails: that is expanded coverage, not a regression. Ran against Dynoxide 0.9.x, where 13 of the new tests fail (redundant parens across expression contexts,
contains()self-operand, non-stringbegins_with,size()UTF-16 counting, negativeSegment); the rest pass. Dynoxide fixes are tracked separately.