`programs.shfmt.indent_size = null` uses tabs rather than `.editorconfig` setting

[l0b0]

I'm migrating to treefmt-nix from pre-commit, and noticed that shfmt by default ignores .editorconfig. But setting programs.shfmt.indent_size = null doesn't work either – all the indentation is changed to tabs.

The relevant settings:

root = true

[*]
indent_size = 4
indent_style = space

[jfly]

@l0b0, thanks for the report! Could you provide repro instructions?

[l0b0]

Yep:

1. Clone and check out this branch.

2. Apply this diff:

   diff --git i/treefmt.nix w/treefmt.nix
   index 7d427518..690cd9c6 100644
   --- i/treefmt.nix
   +++ w/treefmt.nix
   @@ -3,6 +3,7 @@
        deadnix.enable = true;
        nixfmt.enable = true;
        prettier.enable = true;
   +    shfmt.enable = true;
        statix.enable = true;
      };
      settings = {
   

3. Run nix fmt.

[jfly]

Thanks for the repro! You are correct, this completely ignores your .editorconfig file. This is sort of a documentation issue on our end. Please take a look at #443 and let me know if it helps you out!

[l0b0]

Sorry, I just realised I skipped the important bit! The patch should be this:

diff --git c/treefmt.nix i/treefmt.nix
index 0613db5f..c760da2d 100644
--- c/treefmt.nix
+++ i/treefmt.nix
@@ -4,6 +4,10 @@
     nixfmt.enable = true;
     prettier.enable = true;
     shellcheck.enable = true;
+    shfmt = {
+      enable = true;
+      indent_size = null;
+    };
     statix.enable = true;
   };
   settings = {

But yes, you're right, I had to also set simplify = false;.

[jfly]

Or if you use PR you can just set shfmt.useEditorConfig = true and be good to go. With the diff you just shared, if we add another option in the future which defaults to enabled, you'll find that editorconfig support disappears for you.