Use POSIX shell for build.sh script#263
Merged
EpsilonKu merged 1 commit intonvim-pack:masterfrom Apr 28, 2025
Merged
Conversation
Member
|
I used to use |
Contributor
Author
|
Windows doesn't provide either sh or bash in the first place. I suppose it works in WSL as it's literally a Linux sandbox. To my knowledge, /bin/sh is a standard across UNIX OSs (that's why even NixOS provides it). |
Member
|
Alr, I asked gpt. I hope it won't cause any issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/bin/bashdoesn't exist in some niche Linux OSs like Guix or NixOS, but/bin/shdoes. This PR updates the build script to use POSIX shell syntax by replacing==with=. I also added-fflag for all cp commands, so the script can be invoked without fail.