Add option to disable overwriting the dap internal ui#19
Open
mjendruk wants to merge 6 commits into
Open
Conversation
Conni2461
reviewed
Nov 24, 2023
Conni2461
reviewed
Nov 24, 2023
mjendruk
commented
Apr 26, 2024
| setup = function(ext_config) | ||
| vim.cmd [[ highlight default link NvimDapSubtleFrame Comment ]] | ||
|
|
||
| if not vim.F.if_nil(ext_config.overwrite_pick_one, true) then |
Author
There was a problem hiding this comment.
I changed this to true by default so that the old behavior is kept if no value is provided for overwrite_pick_one
Author
|
Hi @Conni2461, I made the changes you requested. Would you take a second look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
thank you for writing and maintaining this very useful plugin. I would like to make one improvement.
I'm using dressing.nvim that already overwrites
vim.ui.selectso I don’t need this plugin to overwrite the internal ui once more.This PR adds an option to disable overwriting the internal ui. I also updated the README.md to reflect this.