telescope-fzf-writer.nvim fails after the merge of #709

[mherna]

Description

I don't know whether to open this in here or in nvim-telescope/telescope-fzf-writer.nvim but after #709 staged_grep() fails to work. I tried seeing if reverting to commit e5fbe6f made staged_grep() work again, and it did.

Expected Behavior
returns search results

Actual Behavior

 8 || ...ck/packer/start/telescope.nvim/lua/telescope/pickers.lua:953: attempt to index field 'sorter' (a boolean value)↲                            
 9 || Error executing luv callback:↲                                                                                                                 
10 || cannot resume dead coroutine↲

Details

run require('telescope').extensions.fzf_writer.staged_grep() and type something.

[yujinyuz]

same. can reproduce the issue with require('telescope').extensions.fzf_writer.files{}

[kkharji]

@Conni2461 What a coincidence!! 😆

I guess won't fix 🤣 because fzf-writer will be deprecated.

[yujinyuz]

@Conni2461 What a coincidence!! 😆

I guess won't fix 🤣 because fzf-writer will be deprecated.

Why won't it get fixed? Is it going to be merged to telescope?

[Conni2461]

@tami5 -.- you legit just jinxed it.

I don't know whats wrong with writer sorry (i have never used it). And we will not merge it into telescope because it requires a external dependency.
But i am working on a telescope-fzf-native.nvim and i am pretty far and @tami5 just spilled the beans 😠

Here are some more spoilers, basically showing how many files match.

I am still working on glue code which will determine, which alg will be called. I already ported all algorithms:

• fuzzy_match_v2
• fuzzy_match_v1
• exact_match_naive
• prefix_match
• suffix_match
• equal_match

So missing, glue code, lua code, testing, so hopefully done till the end of next week

[mherna]

@Conni2461 should I close this issue and just wait for you to finish? 😄

[Conni2461]

Keep it open (i am able to close it if i want 😄). Maybe in the end it will not work out 😆

Also i would prefer if this will be fixed (even though tami wants to deprecate it). We should also port these options:

minimum_grep_characters = 2,
minimum_files_characters = 2,

Btw i am making progress and i am able to parse prompt input:

[kkharji]

Maybe in the end it will not work out

Oh well at least our horrible agreement will be dropped and I will be in peace the following weeks 😆 😆

btw awesome work conni I really admire how much work you put into this so far.

[Conni2461]

A hacky proof of concept works. Still needs more work.

[Conni2461]

Status update abou telescope-fzf-native.nvim progress for everyone subbed to this thread:

Missing:

• invert
• and probably more, i am not thinking about right now 🤣

[yujinyuz]

Status update abou telescope-fzf-native.nvim progress for everyone subbed to this thread:

Missing:

• invert
• and probably more, i am not thinking about right now 🤣

thanks @Conni2461 hoping to get this soon! i miss these features when i was using fzf

[Conni2461]

ignore the last image that one was a LIE and is actually wrong thanks to @jesseleite for pointing that out.

smart_case, ignore_case, respect_case is (hopefully) also implemented. smart_case example:

Release hopefully within the next 24 hours. I will fix one more bug and maybe write some tests.