feat: buf highlights for current buffer fuzzy find#732
Conversation
| items = { | ||
| { width = 5 }, | ||
| { remaining = true }, | ||
| { dynamic_highlight = true, }, |
There was a problem hiding this comment.
Is that actually a thing? I think you solved this differently so we should change that line back to not confuse people reading that code :)
There was a problem hiding this comment.
well technically, I don't think remaining = true does anything either haha
There was a problem hiding this comment.
Good call.
Just thinking out load: We should probably make it explicit and error on wrong key input, so people aren't up being confused if they have a typo, when using width or right_justify or something sunjon wanted some time ago, was right side align, not column but result side (currently not possible because we need to lazy evaluate the result window width).
For me it makes sense to validate the items tbl.
Conni2461
left a comment
Conni2461
left a comment
There was a problem hiding this comment.
Tested it. Works like a charm. Lets ship it :)
Thanks tj :) also treesitter is amazing
|
Amazing work @tjdevries works well |
* upstream/master: picker(live_grep): add option to grep only over open files (nvim-telescope#666) git(action): create and checkout branch (nvim-telescope#755) readme: fix broken links and spelling errors (nvim-telescope#753) added a new DynamicFinder (which can be used with rust_analyzer) (nvim-telescope#705) feat: add icons to git_status finder (nvim-telescope#401) fix: update to newer code (nvim-telescope#744) pickers(buffers): added only_cwd opt (nvim-telescope#739) feat: asyncify pickers - except for live_grep (nvim-telescope#709) fix: Use standardized names for current buffer fuzzy find (nvim-telescope#737) fix(git_branches): use the quoted fields instead of json-formatting and fix regressions with nvim-telescope#695 (nvim-telescope#704) feat: buf highlights for current buffer fuzzy find (nvim-telescope#732)
|
Hey @tjdevries, absolutely love this one, BUT... If I have treesitter highlighting disabled for a specific syntax, ie) require'nvim-treesitter.configs'.setup {
ensure_installed = "maintained",
highlight = {
enable = true,
disable = {'php'},
},
}Opening this finder will not only use treesitter in the results view, but will switch to treesitter highlighting in my actual file buffer as well. I can flip back to polyglot highlighting after closing telescope by running PS. Don't judge me. I want to fully switch to treesitter, but the php implementation is a bit buggy in my experience compared to polyglot. I'll get there though! PSS. Don't judge me, for developing in PHP instead of Rust. |
4 participants
Don't know why the picture is weird, but gives you the right idea at least.