fix(todo_comments): handle nil parser from get_parser on nvim 0.12#338
Merged
jfly merged 1 commit intonvimtools:mainfrom Apr 19, 2026
Merged
fix(todo_comments): handle nil parser from get_parser on nvim 0.12#338jfly merged 1 commit intonvimtools:mainfrom
jfly merged 1 commit intonvimtools:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jfly
reviewed
Apr 18, 2026
Since neovim/neovim#37276 (released in 0.12), vim.treesitter.get_parser() returns nil instead of throwing when no parser is installed for the language. The pcall therefore succeeded with parser == nil, and the subsequent parser:parse() errored with "attempt to index local 'parser' (a nil value)" on any buffer whose filetype has no treesitter grammar. Drop the pcall and check the return value directly. Pass `{ error = false }` so 0.11 also returns nil instead of throwing, on 0.12+ the option is ignored.
r-vdp
force-pushed
the
fix/todo-comments-nil-parser
branch
from
30bced9 to
4f8d399
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since neovim/neovim#37276 (released in 0.12),
vim.treesitter.get_parser()returnsnilinstead of throwing when no parser is installed for the language. Thepcallintodo_commentstherefore succeeds withparser == nil, and the subsequentparser:parse()errors withon any buffer whose filetype has no treesitter grammar installed.
This PR makes the existing guard also bail out when
parserisnil.Checklist
understand it should be contributed to
nvimtools/none-ls-extras.nvim
instead — N/A, bugfix to existing builtin