Conditionals for puppetdb version and default off for max pool size#1
Closed
kpaulisse wants to merge 1 commit intonward:masterfrom
kpaulisse:kpaulisse-puppetdb3-compat
Closed
Conditionals for puppetdb version and default off for max pool size#1kpaulisse wants to merge 1 commit intonward:masterfrom kpaulisse:kpaulisse-puppetdb3-compat
kpaulisse wants to merge 1 commit intonward:masterfrom
kpaulisse:kpaulisse-puppetdb3-compat
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @nward - I found your pull request over at puppetlabs#229 and discovered that you have already added the parameter that I was about to add! Thank you for that! 😸
There was a comment suggesting that you default this to being turned off, and also add compatibility for 3.x. This PR should accomplish both of those things.
I have tested this code with PuppetDB 3.2 and it works. (I have no way to test against 4.0 but presumably you do.) Spec tests pass as well.
Hope this helps!