Open
Conversation
Contributor
|
My suggestion would be to move the part about the GitHub Action in the wiki instead of the official docs. |
Contributor
Author
Maybe both? It's unclear at docs, we need to check the buildbot log for the specific build command. |
|
Fine for me in readme. May be a dedicated Github section for action via build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds clear instructions for packaging built NW.js binaries into a distributable zip archive via Ninja targets. This fills a gap in the existing documentation by offering a standardized method for creating shareable and distributable builds.
Additionally, it includes a tip featuring a seamless GitHub Actions workflow for building NW.js on Windows, which assists Windows developers in bypassing the complexities of manual environment configuration.