Skip to content

Further enhance ROFL app endorsement display#2072

Merged
csillag merged 3 commits into
masterfrom
csillag/enhance-endorsement-display
Jul 25, 2025
Merged

Further enhance ROFL app endorsement display#2072
csillag merged 3 commits into
masterfrom
csillag/enhance-endorsement-display

Conversation

@csillag

@csillag csillag commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

https://pr-2072.oasis-explorer.pages.dev/testnet/sapphire/rofl/app/rofl1qp55evqls4qg6cjw5fnlv4al9ptc0fsakvxvd9uw

Changes:

  • Add links to Endorsement display:
    node, provider, provider_instance_admin, and entity are now displayed as links.
  • Improve displaying AND and OR structures
  • Rephrase the text
Before After
image image
image image

@csillag csillag self-assigned this Jul 16, 2025
@github-actions

github-actions Bot commented Jul 16, 2025

Copy link
Copy Markdown

Deployed to Cloudflare Pages

Latest commit: 1682084dc71919aefdee3b75141f4dfd3312a86c
Status:✅ Deploy successful!
Preview URL: https://563a5ca6.oasis-explorer.pages.dev
Alias: https://pr-2072.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/enhance-endorsement-display branch from 598ddd9 to 8cf60a6 Compare July 16, 2025 08:32
@csillag csillag changed the title Further enhance endorsement display Further enhance ROFL app endorsement display Jul 16, 2025
@csillag csillag force-pushed the csillag/enhance-endorsement-display branch 4 times, most recently from 1451d17 to 59f6c24 Compare July 16, 2025 17:28
@csillag csillag force-pushed the csillag/enhance-endorsement-display branch 2 times, most recently from 86b00ae to cd0f888 Compare July 25, 2025 00:32
@csillag csillag marked this pull request as ready for review July 25, 2025 00:35
Comment thread src/app/pages/RoflAppDetailsPage/Endorsement.tsx
@csillag csillag force-pushed the csillag/enhance-endorsement-display branch 2 times, most recently from a23a1b1 to 8ca9906 Compare July 25, 2025 01:07
Comment thread src/app/components/Account/AccountLink.tsx Outdated
Comment thread src/app/components/HighlightingContext/WithHighlighting.tsx Outdated
Comment thread src/app/pages/RoflAppDetailsPage/Endorsement.tsx Outdated
Comment thread src/app/pages/RoflAppDetailsPage/Endorsement.tsx Outdated
Comment thread src/app/pages/RoflAppDetailsPage/Endorsement.tsx Outdated
Comment thread src/app/pages/RoflAppDetailsPage/Endorsement.tsx Outdated
Comment thread src/app/pages/RoflAppDetailsPage/Endorsement.tsx Outdated
@csillag csillag force-pushed the csillag/enhance-endorsement-display branch from f627c86 to 53ee8e2 Compare July 25, 2025 08:12
@csillag csillag requested a review from lukaw3d July 25, 2025 08:13
@csillag csillag force-pushed the csillag/enhance-endorsement-display branch from 53ee8e2 to b901e05 Compare July 25, 2025 09:48
Move the different versions into different components
@csillag csillag force-pushed the csillag/enhance-endorsement-display branch 3 times, most recently from b3b6fdf to 62adabe Compare July 25, 2025 10:43
@csillag csillag force-pushed the csillag/enhance-endorsement-display branch from 62adabe to f062ef3 Compare July 25, 2025 19:05
@csillag csillag force-pushed the csillag/enhance-endorsement-display branch from f062ef3 to 1682084 Compare July 25, 2025 19:07
@csillag csillag merged commit 8274a0c into master Jul 25, 2025
9 checks passed
@csillag csillag deleted the csillag/enhance-endorsement-display branch July 25, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants