Show balances of same account on other paratimes/consensus#2311
Merged
Conversation
Deployed to Cloudflare Pages
|
Contributor
All looks great to me. Great solution, thanks! Should we inform user that there are transactions in the tooltip if there's no balance rather than saying 'n/a'? |
Contributor
Author
|
Fixed comments from sync meeting |
lukaw3d
force-pushed
the
lw/balance-on-other-layers
branch
from
550a210 to
1dd6c65
Compare
buberdds
approved these changes
Nov 7, 2025
added 8 commits
November 7, 2025 22:08
lukaw3d
force-pushed
the
lw/balance-on-other-layers
branch
from
1dd6c65 to
16756ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1858
Differences from design:
https://pr-2311.oasis-explorer.pages.dev/mainnet/sapphire/address/oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90#root
https://pr-2311.oasis-explorer.pages.dev/mainnet/sapphire/address/0x5d6D0A8fF8355Eb766B8d9Cec37d8e4313166564#root
Before | After
Tooltips
Ignoring tooltip in tooltip weirdness:
cc @donouwens