api/{rofl_apps,evm_tokens}: Filter by multiple name fragments#1026
Conversation
a1b6279 to
cdbc917
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the ROFL apps API by adding support for filtering by multiple name fragments while maintaining backwards compatibility with single-term filters. Key changes include updating test cases and expected responses for multiple names, dynamically constructing the SQL query in the queries module, and adding client-side validation and API specification updates for the new name filtering functionality.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e_regression/eden_testnet_2025/test_cases.sh | Adds a new test case for filtering by multiple names |
| tests/e2e_regression/eden_testnet_2025/expected/sapphire_rofl_app_by_multiple_names.{headers,body} | Provides expected output for the new filter |
| storage/client/queries/queries.go | Replaces the static query with a dynamic SQL query generator for multiple name substrings |
| storage/client/client.go | Adds validation for the number of name filters and updates query assembly |
| api/spec/v1.yaml | Updates API spec to support an array of name strings with a maxItems constraint |
| .changelog/1026.feature.md | Documents the feature update |
cdbc917 to
a8c3d7e
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for filtering by multiple name fragments in both the ROFL apps and EVM tokens API endpoints while maintaining backwards compatibility for a single name filter.
- Updated end-to-end tests and expected responses to validate multiple name filters
- Modified storage client functions to enforce a maximum of 6 name fragments and updated the query logic accordingly
- Revised the OpenAPI spec to reflect an array-based query parameter for name filtering and added corresponding changelog entries
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e_regression/eden_testnet_2025/test_cases.sh | Added a test case for filtering ROFL apps by multiple names |
| tests/e2e_regression/eden_2025/test_cases.sh | Added test cases for filtering EVM tokens by name and multiple names |
| tests/e2e_regression/eden/test_cases.sh | Added test cases for filtering EVM tokens by name and multiple names |
| storage/client/client.go | Implemented filter validation to ensure the number of name fragments does not exceed 6 and updated query construction |
| api/spec/v1.yaml | Updated the API specification to accept an array of strings for the name filter with a maximum of 6 items |
| .changelog/1026.feature.2.md | Added changelog entry for EVM tokens filtering (note potential naming inconsistency) |
| .changelog/1026.feature.1.md | Added changelog entry for ROFL apps filtering |
Comments suppressed due to low confidence (1)
.changelog/1026.feature.2.md:1
- Consider correcting the typo in the changelog entry from 'api/emv_tokens' to 'api/evm_tokens' to maintain consistency with the API endpoint naming.
api/emv_tokens: Support filtering by multiple name fragments
a8c3d7e to
37f3cd4
Compare
Fixes: #1015
Change is backrwads compatible, providing a single name term works as before.
TODO: