Skip to content

fix: move env block to job-level in windows.yml workflow#29650

Open
Rayhan1967 wants to merge 1 commit intoocaml:masterfrom
Rayhan1967:fix/windows-workflow-env-position
Open

fix: move env block to job-level in windows.yml workflow#29650
Rayhan1967 wants to merge 1 commit intoocaml:masterfrom
Rayhan1967:fix/windows-workflow-env-position

Conversation

@Rayhan1967
Copy link
Copy Markdown

Summary

  • Fix invalid YAML syntax in .github/workflows/windows.yml where env block was placed before the on trigger
  • Moved environment variables (OPAMROOT, OPAMSOLVERTIMEOUT, MSYS) to job-level for both analyse and build jobs
  • This follows correct GitHub Actions workflow syntax as per documentation

Changes

Before:

name: Windows CI
on:
  pull_request:
env:          # <-- Invalid: placed before 'on'
  OPAMROOT: D:\opamroot
jobs:
  ...

After:

name: Windows CI
on:
  pull_request:
jobs:
  analyse:
    runs-on: ubuntu-latest
    env:    # <-- Correct: job-level env
      OPAMROOT: D:\opamroot
    ...
  build:
    runs-on: windows-latest
    env:    # <-- Correct: job-level env
      OPAMROOT: D:\opamroot
    ...

Testing

  • YAML syntax validated successfully

- Fix invalid YAML syntax where env was placed before 'on' trigger
- Moved environment variables to job-level for both analyse and build jobs
- This follows correct GitHub Actions workflow syntax
Copy link
Copy Markdown
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those env lines were deleted as part of #29614 which moved the GHA workflows to setup-ocaml.
(this is also the reason for the reported merge conflicts)

As such, this PR is unfortunately no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants