Conversation
New code is mostly copied from the documentation at https://github.com/py-cov-action/python-coverage-comment-action
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often, our CI tests fail just because coveralls is unreachable. The last outage was just the longest one. A second argument is, that CI tests should just make sure that local tests were run. If local tests pass, CI tests should also pass. With Coveralls, this is no longer the case. Thirdly, we often wave through merges even if coverage decreases. The reason is simple: If code is re-factored so that lines of code can be reduced (and tested lines are removed), often also nominal coverage decreases. Thus, the coverage (change) only has informative character anyway.
Concluding, I think it makes sense to remove coveralls from the CI pipeline. (I still like to have the coverage information accessible, nonetheless.)
(Description from oemof/oemof-network#79.)