ruv2: align bypass with request info#1
Closed
disksing wants to merge 1 commit intofeature/ru-scale-default-1.40from
Closed
ruv2: align bypass with request info#1disksing wants to merge 1 commit intofeature/ru-scale-default-1.40from
disksing wants to merge 1 commit intofeature/ru-scale-default-1.40from
Conversation
Signed-off-by: disksing <i@disksing.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestInfoWhy
RU v2 bypass conditions had become broader than the existing resource control bypass rules by also skipping background requests. This change aligns the RU v2 bypass behavior with the existing V1-style request-info bypass semantics.
Testing
go test ./internal/client -run 'TestBypassRUV2FollowsRequestInfoBypass|TestSendRequestAsyncUpdateTiKVRUV2'go test ./tikvrpc -run TestCopStreamResponseRecvBypassRUV2go test ./internal/resourcecontrol -run TestMakeRequestInfoNotes
feature/ru-scale-default-1.40because the branch is stacked on top of that change.