Enable optional skipping of null bytes on dump

[ttr3dp]

Closes: #882

Why?

See #882

What's changed?

• A :skip_null_byte boolean option is introduced. If set to true, null bytes will be omitted from strings when dumping.
• Documentation is updated (docs/mode_table.html and Pages/Options.md)

Example

Oj.dump({ "key\x00" => "val\x00ue" }, :skip_null_byte => true)

# => "{\"key\":\"value\"}"

[ohler55]

You covered all the bases. Nice. Just a couple of comments on the change in dump.c.

[ohler55]

Some formatting issues. If you want to fix them that would be great otherwise I'll merge and fix after merge.

I probably should have resisted the formatters. Nothing but a headache.

[ttr3dp]

Some formatting issues. If you want to fix them that would be great otherwise I'll merge and fix after merge.

I probably should have resisted the formatters. Nothing but a headache.

I fixed 'em.
Although, I'm not sure what are you thoughts on moving dev dependencies from gemspec to Gemfile?
Let me know if this should be in .rubocop_todo.yml maybe? 🤔

[ohler55]

Thank you. My opinion on formatters or linters is generally not good when writing my own project but when working with others it does help. Rubocop is annoying because it keeps changing the rules. gem spec vs Gemfile, I don't care as long as it doesn't keep changing.

I merge with Rubocop failures and fix after the merge. There is no reason for you to forced into that.

[ohler55]

Thank you. My opinion on formatters or linters is generally not good when writing my own project but when working with others it does help. Rubocop is annoying because it keeps changing the rules. gem spec vs Gemfile, I don't care as long as it doesn't keep changing.

I'll merge with Rubocop failures and fix after the merge. There is no reason for you to forced into that. I am seeing other failures though that were not there on the last run.

[ohler55]

Maybe revert the gemfile change and go back to just rubicon failing and the rest passing.

[ttr3dp]

Maybe revert the gemfile change and go back to just rubicon failing and the rest passing.

Done!

[ohler55]

Thanks, I'll see what I can do about the Rubocop issue and release tonight.

[ohler55]

It's going to take a bit more to get all the rubocop stuff addressed.

[ohler55]

I'll move and rename the option as well. Sorry, I should have noticed it was not in the dump options. Renaming it to omit_null_byte for consistency. Would get it done along with the rubocop stuff tonight.

[ohler55]

v3.15.0 released with :omit_null_byte option.

[ttr3dp]

THANK YOU for literally everything. Time, patience, understanding, sharing the knowledge and so much more.

As for the changes...I agree, omit_null_byte is more consistent 👍

I'm truly glad I could contribute to such a useful project and learn a lot in the process.

Thanks again!