Expose whether bin/lib target has tests enabled

[RalfJung]

There currently seems to be no way to figure out if a bin/lib target has tests enabled. Would be great if that information was made available -- I think that is required to solve rust-lang/miri#700.

[ehuss]

The information isn't exposed from Cargo. The additional fields need to be added to SerializedTarget.

[RalfJung]

Oh I see...

Btw, the comment "Serialized as a list of strings for historical reasons" for the kind field, does this mean we can rely on that list to always contain exactly one element? It is not clear from the comment what type would be used if it wasn't for historical reasons.

[ehuss]

rely on that list to always contain exactly one element?

No. The documentation that explains the fields is here.

I'm only guessing, but I think it would have been preferred for libraries to have a value of "lib", instead of the array of crate-types.

[RalfJung]

Oh wow, I think Miri is getting that wrong then... we just check for "lib".

The "etc" doesn't exactly help when one wants to be sure to cover all lib crates.^^

[oli-obk]

Uh... so is there any action that I can do about this in cargo_metadata or is it essentially resolved?

[RalfJung]

It's not resolved but blocked on cargo exposing test = true/false.

[oli-obk]

The cargo PR has been merged

[RalfJung]

Awesome. :D
Does this crate also need updating or is that picked up automatically somehow?

[oli-obk]

no, we need to wait for this information to make it to a release and then add the appropriate field