This repository was archived by the owner on Oct 20, 2023. It is now read-only.
Merged
Conversation
fix: increase block search offset fix: make block search offset configurable
Owner
|
Thanks a ton for your contribution. 👍 |
This was referenced Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves how miningcore classifies uncles on ethereum and prevents miningcore from trying to insert a block twice.
This PR also adds a new config option to fine tune the search range for uncles. I noticed that 50 is to low on certain ethereum type blockchains. By increasing the value to 75 or 100, miningcore could confirm a lot of blocks which were previously marked as orphans.
closes #1080