Test lower protoc version in Linux CI#4365
Merged
Conversation
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
gramalingam
approved these changes
Jul 20, 2022
…o jcw/mini-protoc Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> # Conflicts: # .github/workflows/manylinux/entrypoint.sh
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Member
Author
|
One important change I would like to highlight is that this PR makes released ONNX wheel for Linux and Mac start to use It's possible that Linux users use older protoc versions (e.g., 3.0.0) from apt-get. Although using prebuilt wheel should be a fine case, to be safe, I tested the ONNX Linux wheel, which was built with |
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Closed
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* use apt-get's libprotobuf-dev Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * change order Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use Git instead of opeartor[] Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use index Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * -DONNX_USE_PROTOBUF_SHARED_LIBS=ON Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * shape_inference test as well Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * test onnx_lite in GitHub Action instead Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove duplicate pip install Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix warnings in script Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix the rest of warnings Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * update docment Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use $4 instead Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use sh instead of shell Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use $1 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * failed_wheels Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add doc Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * missing $1 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use $4 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use original Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * onnx_lite does not work with old protoc version Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * make Mac use ONNX_USE_LITE_PROTO to sync options for all envs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * update CI doc to reflect recent changes Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
For now there is no CI in ONNX testing lower protoc version. For instance, using libprotobuf-dev and protobuf-compiler from apt-get. ONNX mention this usage in the document and ideally the CI should cover this case.