add docs for cpp tests requiring built libraries#4401
Merged
Conversation
williamberman
commented
Aug 1, 2022
jcwchen
reviewed
Aug 1, 2022
williamberman
force-pushed
the
will/ld-library-path-docs
branch
from
1ddc87d to
b7ed691
Compare
jcwchen
reviewed
Aug 2, 2022
add jcwchen change for windows Signed-off-by: Will Berman <WLBberman@gmail.com> Update docs/CONTRIBUTING.md Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
williamberman
force-pushed
the
will/ld-library-path-docs
branch
from
fd39637 to
f3708d9
Compare
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
add jcwchen change for windows Signed-off-by: Will Berman <WLBberman@gmail.com> Update docs/CONTRIBUTING.md Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update contributor guidelines to note cpp tests require linking to built libraries (i.e. ONNXIFI_DUMMY_LIBRARY).
Motivation and Context