Format all python code with black and isort - take 2#4427
Merged
gramalingam merged 7 commits intoonnx:mainfrom Aug 10, 2022
Merged
Format all python code with black and isort - take 2#4427gramalingam merged 7 commits intoonnx:mainfrom
gramalingam merged 7 commits intoonnx:mainfrom
Conversation
justinchuby
changed the title
Member
Author
|
@jcwchen I created this pr to set up the config and CI for the formatters. Please let me know when the approved changes are merged and I can run the actual formatting process |
Signed-off-by: Justin Chu <justinchu@microsoft.com> update isort Signed-off-by: Justin Chu <justinchu@microsoft.com> update config Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
justinchuby
force-pushed
the
justinchu/format-all-3
branch
from
cdab63a to
9ce9cfe
Compare
Signed-off-by: Justin Chu <justinchu@microsoft.com>
justinchuby
force-pushed
the
justinchu/format-all-3
branch
from
bc1c304 to
d650a8d
Compare
jcwchen
reviewed
Aug 10, 2022
Member
Author
|
Do we check for output_X.pb in the CI? I ran tools/update_doc.sh and got those. I will revert the changes |
justinchuby
force-pushed
the
justinchu/format-all-3
branch
from
d650a8d to
d8d9145
Compare
Member
Author
|
Done |
Member
Author
|
@gramalingam ready for your approval |
gramalingam
approved these changes
Aug 10, 2022
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* Add black and isort into requirement Signed-off-by: Justin Chu <justinchu@microsoft.com> update isort Signed-off-by: Justin Chu <justinchu@microsoft.com> update config Signed-off-by: Justin Chu <justinchu@microsoft.com> * Add ci Signed-off-by: Justin Chu <justinchu@microsoft.com> reset ci Signed-off-by: Justin Chu <justinchu@microsoft.com> fix linux ci Signed-off-by: Justin Chu <justinchu@microsoft.com> * Skip formatting the init file Signed-off-by: Justin Chu <justinchu@microsoft.com> * Black isort Signed-off-by: Justin Chu <justinchu@microsoft.com> * Gen docs Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Standardize formatting
Fixes #4278