avoid modifying node when creating test cases#4517
Conversation
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
jcwchen
approved these changes
Sep 15, 2022
…he original node Signed-off-by: Liqun Fu <liqfu@microsoft.com>
gramalingam
approved these changes
Sep 20, 2022
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liqun Fu liqfu@microsoft.com
Description
avoid modifying node when creating test cases
Motivation and Context
An operator node is used to create test cases. Sometimes a node is used to create multiple test cases. This requires that the node is immutable when creating a test case. This is especially true when a test with default attributes. In this PR, change is added to avoid default attributes being added to the original node which will cause subsequent test case creation failure.
This bug was detected when changing ReduceSumSquare to function op. When extended cases were created, a attribute of empty attribute was added to the original node which cause the next test case to fail.