Consider GraphInferenceContext in inference functions: InferenceContext#4632
Merged
Consider GraphInferenceContext in inference functions: InferenceContext#4632
Conversation
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
gramalingam
reviewed
Nov 2, 2022
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
changed the title
jcwchen
commented
Nov 2, 2022
jcwchen
changed the title
gramalingam
reviewed
Nov 9, 2022
gramalingam
reviewed
Nov 9, 2022
Contributor
|
Adding a test-case would be useful |
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
force-pushed
the
jcw/extend-subgraph
branch
from
83be312 to
ce5f874
Compare
jcwchen
commented
Nov 17, 2022
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
gramalingam
reviewed
Nov 17, 2022
| subgraph = make_graph( | ||
| [ | ||
| make_node("Identity", ["loop_state_in"], ["loop_state_out"]), | ||
| make_node("Identity", ["input"], ["output"]), |
Contributor
There was a problem hiding this comment.
Can we change this to include an outer-scope variable reference? Like
make_node("Add", ["input", "outer"], ["output"]),
gramalingam
reviewed
Nov 17, 2022
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
gramalingam
reviewed
Nov 18, 2022
| input_types: Dict[str, onnx.TypeProto], | ||
| input_data: Optional[Dict[str, onnx.TensorProto]] = None, | ||
| input_sparse_data: Optional[Dict[str, onnx.SparseTensorProto]] = None, | ||
| subgraph_opset_imports: Optional[List[onnx.OperatorSetIdProto]] = None, |
Contributor
There was a problem hiding this comment.
minor nit: I think opset_imports and ir_version might be sufficient as the parameter names. I realize they are used only for subgraphs, but it is unlikely to cause any confusion or ambiguity to use the shorter name. It will be easier for callers, when they use keyword-arguments.
Member
Author
There was a problem hiding this comment.
I was in the debate of opset_imports and subgraph_opset_imports, but yes I agreed using shorter name here is cleaner. Just updated. Will merge this PR soon. Thank you for bringing this up!
gramalingam
approved these changes
Nov 18, 2022
Contributor
gramalingam
left a comment
gramalingam
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just have one minor comment about naming of parameters.
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
gramalingam
approved these changes
Nov 18, 2022
justinchuby
pushed a commit
to justinchuby/onnx
that referenced
this pull request
Jan 27, 2023
…xt (onnx#4632) * Expose GraphInferenceContext in Python interface for inference functions Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use the same map Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add opset_imports and handle input_types Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * graph_opset_import to clarify Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix lint Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix black Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add a test Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * make_opsetid Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * replace test with Add in subgraph Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unused Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use shorter name for opset_imports and ir_version Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
…xt (onnx#4632) * Expose GraphInferenceContext in Python interface for inference functions Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use the same map Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add opset_imports and handle input_types Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * graph_opset_import to clarify Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix lint Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix black Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add a test Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * make_opsetid Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * replace test with Add in subgraph Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unused Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use shorter name for opset_imports and ir_version Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Follow up for #4409. Further consider GraphInferenceContext for inference function