fix(fe): projects buttons transition in like other sidebar items#9875
Open
fix(fe): projects buttons transition in like other sidebar items#9875
Conversation
Contributor
|
Preview Deployment
|
Contributor
Greptile SummaryThis is a minimal, targeted CSS fix that corrects the Projects buttons' transition animation in the sidebar. Changing
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[SidebarTab render] --> B{children is string?}
B -->|Yes| C[ContentAction component\nwith icon + title + truncationSpacer]
B -->|No| D["div.flex.flex-row.items-center.gap-2.w-full\n(was flex-1 — caused animation glitch)"]
D --> E{Icon present?}
E -->|Yes| F[Icon div with p-0.5 padding]
E -->|No| G[Skip icon]
F --> H[children node]
G --> H
H --> I[truncationSpacer]
C --> J{folded mode?}
J -->|Yes| K[Wrap in Radix Tooltip]
J -->|No| L[Return content directly]
Reviews (1): Last reviewed commit: "fix(fe): projects buttons transition in ..." | Re-trigger Greptile |
Contributor
🖼️ Visual Regression Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Projects buttons transition in from outside the viewport. This fixes it so that the projects buttons transition in similarly to the other buttons in the sidebar.
Per Claude,
How Has This Been Tested?
Opened the sidebar and confirmed transition is smooth
Additional Options
Summary by cubic
Fixes the Projects buttons so they animate like other sidebar items. The buttons no longer slide in from off-screen during sidebar resize.
SidebarTab, replacedflex-1withw-fullon the non-string children wrapper to ensure full-width during transitions. Icons stay pinned left and the animation is smooth.Written for commit 2af6a2d. Summary will update on new commits.