feat: add Jira Service Management (JSM) connector#9881
Open
VasuBansal7576 wants to merge 1 commit intoonyx-dot-app:mainfrom
Open
feat: add Jira Service Management (JSM) connector#9881VasuBansal7576 wants to merge 1 commit intoonyx-dot-app:mainfrom
VasuBansal7576 wants to merge 1 commit intoonyx-dot-app:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
There was a problem hiding this comment.
1 issue found across 14 files
Confidence score: 5/5
- This PR looks low risk; the only noted issue is a low-severity (3/10) maintainability concern rather than a functional bug.
web/src/lib/connectors/connectors.tsxduplicates Jira config for Jira Service Management, which could drift over time but should not affect current behavior.- Pay close attention to
web/src/lib/connectors/connectors.tsx- duplicated config could diverge later.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="web/src/lib/connectors/connectors.tsx">
<violation number="1" location="web/src/lib/connectors/connectors.tsx:748">
P3: Jira Service Management’s form config is a near copy of the existing Jira config, which creates duplication that can drift when one is updated. Consider sharing a common base config or extracting the shared fields to avoid maintaining two copies.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| ], | ||
| advanced_values: [], | ||
| }, | ||
| jira_service_management: { |
Contributor
There was a problem hiding this comment.
P3: Jira Service Management’s form config is a near copy of the existing Jira config, which creates duplication that can drift when one is updated. Consider sharing a common base config or extracting the shared fields to avoid maintaining two copies.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At web/src/lib/connectors/connectors.tsx, line 748:
<comment>Jira Service Management’s form config is a near copy of the existing Jira config, which creates duplication that can drift when one is updated. Consider sharing a common base config or extracting the shared fields to avoid maintaining two copies.</comment>
<file context>
@@ -745,6 +745,91 @@ export const connectorConfigs: Record<
],
advanced_values: [],
},
+ jira_service_management: {
+ description: "Configure Jira Service Management connector",
+ subtext: `Configure which Jira Service Management content to index. You can index everything or specify a particular project.`,
</file context>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



/claim #2281
Summary
Adds a JiraServiceManagementConnector that indexes tickets from a specified JSM project (Service Request, Incident, Problem, Change, Service Task).
Approach
Rather than duplicating the existing JiraConnector logic, this PR implements JiraServiceManagementConnector as a thin subclass of JiraConnector, overriding only 3 hooks:
All checkpointing, authentication, pagination, slim docs, and incremental sync logic is inherited from the parent — zero duplication.
Files Changed
Tests
2 passed — ran: cd backend && python -m pytest tests/daily/connectors/jira_service_management/ -v
Closes #2281
Summary by cubic
Adds a
JiraServiceManagementConnectorto index Jira Service Management tickets with zero logic duplication by subclassingJiraConnector. Addresses Linear #2281 by meeting the requirement to ingest Service Request, Incident, Problem, Change, and Service Task issues.New Features
JiraServiceManagementConnectorwith JSM issue type filter andDocumentSource.JIRA_SERVICE_MANAGEMENT.jira_service_managementin the backend registry and source metadata; added UI config, credentials, autosync, and title handling.Refactors
JiraConnectornow exposes overridablesource,source_display_name, andjql_issue_type_filter; error and credential messages use display name, andprocess_jira_issueacceptssource.onyx.connectors.onyx_jirafor clean re-exports ofJiraConnectorand helpers.Written for commit f9ebf2b. Summary will update on new commits.