Skip to content

🐛 Reduce permission for cluster manager and klusterlet#325

Merged
openshift-merge-bot[bot] merged 1 commit intoopen-cluster-management-io:mainfrom
qiujian16:reduce-permission
Nov 30, 2023
Merged

🐛 Reduce permission for cluster manager and klusterlet#325
openshift-merge-bot[bot] merged 1 commit intoopen-cluster-management-io:mainfrom
qiujian16:reduce-permission

Conversation

@qiujian16
Copy link
Copy Markdown
Member

@qiujian16 qiujian16 commented Nov 29, 2023 •
edited
Loading

@openshift-ci openshift-ci Bot requested review from deads2k and jnpacker November 29, 2023 09:59
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a1a890) 61.76% compared to head (ea05bb9) 61.73%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   61.76%   61.73%   -0.04%     
==========================================
  Files         132      132              
  Lines       13989    13992       +3     
==========================================
- Hits         8641     8638       -3     
- Misses       4583     4587       +4     
- Partials      765      767       +2
Flag Coverage Δ
unit 61.73% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16 qiujian16 force-pushed the reduce-permission branch 4 times, most recently from 3b2bb6c to 2a2e995 Compare November 30, 2023 07:11
@qiujian16
Reduce permission for cluster manager and klusterlet
ea05bb9 
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@zhiweiyin318
Copy link
Copy Markdown
Member

zhiweiyin318 commented Nov 30, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Nov 30, 2023
@openshift-merge-bot openshift-merge-bot Bot merged commit 7ceb9a2 into open-cluster-management-io:main Nov 30, 2023
@qiujian16 qiujian16 deleted the reduce-permission branch November 30, 2023 13:48
@sparkEchooo
Copy link
Copy Markdown

sparkEchooo commented Dec 4, 2023 •
edited
Loading

Thanks for your reply!
The fixes is effective.
By the way, if it's a real issue and has been fixed, can I get a CVE-number:)
Looking forward to your reply!

@sparkEchooo sparkEchooo mentioned this pull request Jun 23, 2024
Closed
@GoVulnBot GoVulnBot mentioned this pull request Dec 18, 2024
Closed
elgnay pushed a commit to elgnay/ocm that referenced this pull request Jun 12, 2025
@red-hat-konflux
Konflux build pipeline service account migration for addon-manager-mc…
f6f19c5 
…e-27 (open-cluster-management-io#325)

Signed-off-by: konflux <konflux@no-reply.konflux-ci.dev>

Co-authored-by: konflux <konflux@no-reply.konflux-ci.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@jnpacker jnpacker Awaiting requested review from jnpacker

Assignees

@zhiweiyin318 zhiweiyin318

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A potential risk of operator makes a worker node get the token of any Service Account

3 participants

@qiujian16 @zhiweiyin318 @sparkEchooo
⚡