Skip to content

TransmitterPdu has double extraction of RadioID #11

@arrowsmith

Description

@arrowsmith

Hi again Don @brutzman,

I have noticed the TransmitterPdu class extracts the RadioID field (ref) once inside the header field (see RadioCommsHeader class), and again separately in the radioNumber field. this causes an unnecessary shift of unmarshalling by 2 bytes. Removing it from the RadioCommsHeader class fixes the problem, but so does commenting out the local field to the TransmitterPdu class, and redirecting all calls to get/set of the RadioID to the embedded RadioCommsHeader instance's field. I'm not sure which way you want to go.

Let me know if you're the best POC, or if there's a preferred approach to raising these issues.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions