Skip to content

feat(configgrpc): respect status error#14010

Merged
mx-psi merged 7 commits intoopen-telemetry:mainfrom
therealpandey:main
Oct 21, 2025
Merged

feat(configgrpc): respect status error#14010
mx-psi merged 7 commits intoopen-telemetry:mainfrom
therealpandey:main

Conversation

@therealpandey
Copy link
Copy Markdown
Contributor

@therealpandey therealpandey commented Oct 13, 2025

Description

  • respect status error received from authenticator

Link to tracking issue

Fixes #14005

@therealpandey therealpandey mentioned this pull request Oct 13, 2025
Closed
@therealpandey therealpandey marked this pull request as ready for review October 13, 2025 18:03
@therealpandey therealpandey requested a review from a team as a code owner October 13, 2025 18:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.58%. Comparing base (4843f59) to head (84b4ca8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14010      +/-   ##
==========================================
- Coverage   91.62%   91.58%   -0.05%     
==========================================
  Files         655      655              
  Lines       42786    42790       +4     
==========================================
- Hits        39203    39188      -15     
- Misses       2761     2775      +14     
- Partials      822      827       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dmathieu
dmathieu reviewed Oct 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry?

@therealpandey
Copy link
Copy Markdown
Contributor Author

therealpandey commented Oct 14, 2025

Sure @dmathieu. Let me do that.

@therealpandey
Copy link
Copy Markdown
Contributor Author

therealpandey commented Oct 14, 2025

Added the changelog @dmathieu

@therealpandey
Copy link
Copy Markdown
Contributor Author

therealpandey commented Oct 15, 2025

Let me know how it looks now!

@dmathieu dmathieu mentioned this pull request Oct 15, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Oct 15, 2025
@dmathieu @songy23 @codeboten
Add metadata files for all config packages (#14029)
fbb78c6 
All those config packages expose public structs/interfaces, and need to
be able to have changelog entries.
Related:
#14010

---------

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
dmathieu
dmathieu approved these changes Oct 16, 2025
View reviewed changes
Comment thread .chloggen/14005.yaml Outdated
@therealpandey
Copy link
Copy Markdown
Contributor Author

therealpandey commented Oct 16, 2025

@dmathieu the component was pkg/config/configgrpc. I have updated the chlog. Can we run the CI again?

@therealpandey
Copy link
Copy Markdown
Contributor Author

therealpandey commented Oct 16, 2025

Hi @dmathieu,
Sorry to keep troubling you, is it possible to merge this now? The branch has fallen out of sync with main again.

@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Oct 16, 2025

Merging requires an approval/merge by a maintainer. No need to keep updating the branch unless there's a conflict though.

@mx-psi mx-psi added this pull request to the merge queue Oct 17, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@mx-psi mx-psi enabled auto-merge October 17, 2025 19:48
@therealpandey
Copy link
Copy Markdown
Contributor Author

therealpandey commented Oct 20, 2025

Hi @mx-psi,
Sorry to disturb you again, can you please re-run the CI? I see the contrib PR has been closed to allow merges here.

@mx-psi mx-psi added this pull request to the merge queue Oct 21, 2025
Merged via the queue into open-telemetry:main with commit 5174026 Oct 21, 2025
59 checks passed
@github-actions github-actions Bot added this to the next release milestone Oct 21, 2025
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Oct 21, 2025

Thank you for your contribution @therealpandey! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmathieu dmathieu dmathieu approved these changes

@mx-psi mx-psi mx-psi approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.139.0

Development

Successfully merging this pull request may close these issues.

[configgrpc] respect auth extension error codes

3 participants

@therealpandey @dmathieu @mx-psi
⚡