Prefer arrays of name value pairs over objects#115
Merged
jack-berg merged 7 commits intoopen-telemetry:mainfrom Sep 19, 2024
Merged
Prefer arrays of name value pairs over objects#115jack-berg merged 7 commits intoopen-telemetry:mainfrom
jack-berg merged 7 commits intoopen-telemetry:mainfrom
Conversation
trask
reviewed
Sep 1, 2024
marcalff
reviewed
Sep 2, 2024
Member
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the PR.
See comments.
a4248d9 to
2849441
Compare
codeboten
reviewed
Sep 6, 2024
Contributor
codeboten
left a comment
There was a problem hiding this comment.
Just a couple of comments, otherwise this looks ok to me
Closed
…y-configuration into prefer-name-value-pairs
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
…g/opentelemetry-configuration into prefer-name-value-pairs
Member
Author
|
@marcalff, @codeboten - I've resolved merge conflicts and incorporated feedback. Can you take another look? Thanks. |
codeboten
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #72.
May also resolve open-telemetry/opentelemetry-specification#2857.
This PR migrates
.resource.attributesand*.otlp.headersto be key-value pairs instead of objects, and adds a modeling rule to follow this pattern for similar situations in the future. To repeat the reasoning from the modeling rule:The more I think about it, the more I think this the way the way to go. Note that this is how environment variables are specified in kubernetes manifests, so it shouldn't be particularly foreign to users.
We should get this change in sooner than later to minimize the number of users we expose to churn.