Skip to content

Make implementation status notes optional#366

Merged
jack-berg merged 6 commits intoopen-telemetry:mainfrom
jack-berg:delete-implementation-status-notes
Nov 13, 2025
Merged

Make implementation status notes optional#366
jack-berg merged 6 commits intoopen-telemetry:mainfrom
jack-berg:delete-implementation-status-notes

Conversation

@jack-berg
Copy link
Copy Markdown
Member

@jack-berg jack-berg commented Nov 1, 2025

Implementation status notes are not used right now and add a lot of clutter to the meta_schema_language_{language}.yaml documents.

This PR makes them optional.

@jack-berg jack-berg requested a review from a team as a code owner November 1, 2025 18:46
@marcalff
Copy link
Copy Markdown
Member

marcalff commented Nov 1, 2025

We've had two implementation statuses reported and no notes recorded. Let's delete this and de-clutter the implementation status YAML files. Can restore later if a use case emerges.

In case of translation_strategy for prometheus, I have a case where not all enum values are supported.

I did not have time to provide details yet, but notes can be helpful for some edge cases.

@jack-berg
Copy link
Copy Markdown
Member Author

Good feedback. Will adjust to make it an optional addition, instead of automatically included on every type.

@jack-berg jack-berg force-pushed the delete-implementation-status-notes branch from 4301762 to e60a95c Compare November 4, 2025 17:23
@jack-berg jack-berg changed the title Delete implementation status notes Make implementation status notes optional Nov 4, 2025
@jack-berg
Copy link
Copy Markdown
Member Author

Updated to retain implementation status notes but make them optional.

Copy link
Copy Markdown
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff
Copy link
Copy Markdown
Member

Makes sense. Please rebase.

@jack-berg jack-berg force-pushed the delete-implementation-status-notes branch from f83909a to 64709c3 Compare November 13, 2025 02:47
@jack-berg jack-berg force-pushed the delete-implementation-status-notes branch from 64709c3 to ad893d1 Compare November 13, 2025 02:48
@jack-berg jack-berg merged commit aa03c9d into open-telemetry:main Nov 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants