Logger-Support-for-Instrumentation-library#1149
Logger-Support-for-Instrumentation-library#1149ThomsonTan merged 15 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
+ Coverage 93.29% 93.29% +0.01%
==========================================
Files 174 174
Lines 6402 6404 +2
==========================================
+ Hits 5972 5974 +2
Misses 430 430
|
| // The logger provider of this Logger. Uses a weak_ptr to avoid cyclic dependency issues the with | ||
| // logger provider | ||
| std::weak_ptr<LoggerProvider> logger_provider_; | ||
| std::shared_ptr<instrumentationlibrary::InstrumentationLibrary> instrumentation_library_; |
There was a problem hiding this comment.
I understand this is coming from tracer implementation, but now thinking why do store it as shared_ptr instead of unique_ptr, or as value. We are anyway passing it to exporters as reference.
| */ | ||
| virtual void SetInstrumentationLibrary( | ||
| const opentelemetry::sdk::instrumentationlibrary::InstrumentationLibrary | ||
| &instrumentation_library) noexcept = 0; |
There was a problem hiding this comment.
We need to call this method from within Logger::Log() for exporters to be able to read this. Do we plan to have it as separate PR?
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
|
@ThomsonTan - Can you pls have a look to this PR. Thanks. |
| auto logger2 = tf->GetLogger("logger2", args); | ||
| std::array<nostd::string_view, 1> sv{"string"}; | ||
| nostd::span<nostd::string_view> args{sv}; | ||
| auto logger2 = tf->GetLogger("logger2", args, "lib_name", "", schema_url); |
There was a problem hiding this comment.
nit: use another fake library name like opentelelemtry_library and make it consistent in all the tests?
|
Would it be possible to rerun the CI jobs? |
3 participants
Fixes #1087 (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes