allow extension of the lifetime of ContextStorage.#1214
Merged
lalitb merged 6 commits intoopen-telemetry:mainfrom Feb 19, 2022
Merged
allow extension of the lifetime of ContextStorage.#1214lalitb merged 6 commits intoopen-telemetry:mainfrom
lalitb merged 6 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 196 196
Lines 7038 7038
=======================================
Hits 6544 6544
Misses 494 494
|
lalitb
approved these changes
Feb 15, 2022
Contributor
|
Could we provide some dedicated helper method to increase the lifetime of RuntimeStorage? As the user cannot deduce the purpose of this API directly from the API name. |
Member
Author
Could you please elaborate? |
Contributor
I meant some explicit API like |
ThomsonTan
approved these changes
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1211 (issue)
Changes
The specifications require the context to be immutable, but does not talk about whether the users are allowed to have access to the storage.
The change in this PR allows the users to get a shared_ptr to const so they can't do anything with the pointer but extending the lifetime of the storage.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes