[Metric SDK] Synchronous Instruments - Aggregation Storage(s) creation for configured views#1219
Merged
lalitb merged 18 commits intoopen-telemetry:mainfrom Feb 24, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1219 +/- ##
==========================================
- Coverage 92.96% 92.31% -0.65%
==========================================
Files 196 198 +2
Lines 7040 7118 +78
==========================================
+ Hits 6544 6570 +26
- Misses 496 548 +52
|
esigo
reviewed
Feb 19, 2022
esigo
reviewed
Feb 19, 2022
esigo
reviewed
Feb 19, 2022
esigo
reviewed
Feb 19, 2022
…pp into meter-filter-view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1217
Changes
Create and store Aggregation Storage(s) as per the logic described in #1217
Refer to the flow in architecture ( https://docs.google.com/document/d/17PiDI91MQy07kkiSJ7lvlnogvMD3FV85g__WEackj1M ) which shows Aggregation Storage as SyncMetricStorage and AsyncMetricStorage, and the same name is used in the code.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes