Enable bazel build for metrics proto files#1489
Merged
lalitb merged 3 commits intoopen-telemetry:mainfrom Jul 12, 2022
Merged
Conversation
Contributor
|
Is OTLP gRPC metrics exporter enabled in bazel? |
Codecov Report
@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
+ Coverage 84.65% 84.67% +0.03%
==========================================
Files 155 155
Lines 4787 4787
==========================================
+ Hits 4052 4053 +1
+ Misses 735 734 -1
|
ThomsonTan
approved these changes
Jul 12, 2022
Member
Author
Not yet, will create a PR for that once this is merged. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
~/bazel/opentelemetry_proto.BUILDfile only contains the build rules for traces and logs. Adding build rules for metrics too.Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes