Skip to content

Link opentelemetry_api to ETW exporter test#1503

Merged
lalitb merged 2 commits intomainfrom
FixETW
Jul 19, 2022
Merged

Link opentelemetry_api to ETW exporter test#1503
lalitb merged 2 commits intomainfrom
FixETW

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

@ThomsonTan ThomsonTan commented Jul 19, 2022

Fixes building ETW log exporter test.

The macro ENABLE_LOGS_PREVIEW is defined here as opentelemetry_api, the ETW exporter test needs to link to this target to get the macro definition.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team July 19, 2022 08:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2022

Codecov Report

Merging #1503 (85a1449) into main (24d5100) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1503      +/-   ##
==========================================
- Coverage   84.72%   84.66%   -0.06%     
==========================================
  Files         156      156              
  Lines        4784     4784              
==========================================
- Hits         4053     4050       -3     
- Misses        731      734       +3     
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 79.93% <0.00%> (-1.13%) ⬇️

@lalitb lalitb merged commit abf3312 into main Jul 19, 2022
@lalitb lalitb deleted the FixETW branch July 19, 2022 15:04
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants