Fix code scanning alert

[esigo]

Fixes #1529 (issue)

Changes

uses HTTPS URLs

For significant contributions please make sure you have completed the following items:

• CHANGELOG.md updated for non-trivial changes
• Unit tests have been added
• Changes in public API reviewed

[codecov]

Codecov Report

Merging #1530 (b2d6a35) into main (b4d8245) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
+ Coverage   84.57%   84.63%   +0.07%     
==========================================
  Files         156      156              
  Lines        4795     4795              
==========================================
+ Hits         4055     4058       +3     
+ Misses        740      737       -3     

Impacted Files	Coverage Δ
ext/src/http/client/curl/http_client_curl.cc	81.07% <0.00%> (+1.14%)	⬆️

[ThomsonTan]

Wondering why is the IP address changed? I think it is intended as some invalid/unreachable address. @lalitb

[owent]

I think this address is invalid either

[ThomsonTan]

Some local app could listen on https://127.0.0.1:19000?

[lalitb]

We can also use the address from Documentation Address Block (https://datatracker.ietf.org/doc/html/rfc5737#section-4), as they are not allowed to be used on the public internet, and so would be always unreachable.

192.0.2.0 – 192.0.2.255
198.51.100.0 – 198.51.100.255
233.252.0.0 - 233.252.0.255

[owent]

LGTM

[esigo]

Hi @owent, do you have any idea why the asan test fails:

ext/test/http/curl_http_test.cc:429: Failure
Value of: sessions[i]->IsSessionActive()
  Actual: false
Expected: true

I can't reproduce it locally.
thanks

[owent]

Hi @owent, do you have any idea why the asan test fails:

ext/test/http/curl_http_test.cc:429: Failure
Value of: sessions[i]->IsSessionActive()
  Actual: false
Expected: true

I can't reproduce it locally. thanks

Some implements of libcurl will connect failed immediately and call the callback in the IO thread if it try to connect a invalid address. And the callback will reset is_session_active_ to false.Maybe we can add GetEventHandler::OnEvent() to set is_called_ and use ASSERT_TRUE(sessions[i]->IsSessionActive() || handlers[i]->is_called_); here.

[esigo]

Hi @owent, do you have any idea why the asan test fails:

ext/test/http/curl_http_test.cc:429: Failure
Value of: sessions[i]->IsSessionActive()
  Actual: false
Expected: true

I can't reproduce it locally. thanks

Some implements of libcurl will connect failed immediately and call the callback in the IO thread if it try to connect a invalid address. And the callback will reset is_session_active_ to false.Maybe we can add GetEventHandler::OnEvent() to set is_called_ and use ASSERT_TRUE(sessions[i]->IsSessionActive() || handlers[i]->is_called_); here.

Thanks @owent, it fixed :)