[MINOR]: Fix ObservableInstrument::RemoveCallback#1582
Merged
lalitb merged 1 commit intoopen-telemetry:mainfrom Aug 26, 2022
Merged
[MINOR]: Fix ObservableInstrument::RemoveCallback#1582lalitb merged 1 commit intoopen-telemetry:mainfrom
lalitb merged 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
+ Coverage 85.00% 85.02% +0.03%
==========================================
Files 156 156
Lines 4977 4977
==========================================
+ Hits 4230 4231 +1
+ Misses 747 746 -1
|
lalitb
approved these changes
Aug 26, 2022
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the issue of not being able to de-register async instrument callbacks.