Merged
Conversation
lalitb
approved these changes
Nov 9, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1757 +/- ##
==========================================
+ Coverage 85.77% 85.79% +0.02%
==========================================
Files 171 171
Lines 5212 5212
==========================================
+ Hits 4470 4471 +1
+ Misses 742 741 -1
|
marcalff
approved these changes
Nov 10, 2022
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the cleanup
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes