Migrate from @bazel_tools//platforms to https://github.com/bazelbuild/platforms

[davidmandle]

Changes

This MR migrates platforms constraints from the deprecated @bazel_tools//platforms target to instead depend on the https://github.com/bazelbuild/platforms repository, per bazelbuild/bazel#8622

This enables compatibility with the newly released Bazel 6.0.0.

[codecov]

Codecov Report

Merging #1873 (add3020) into main (94a6783) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1873      +/-   ##
==========================================
- Coverage   85.79%   85.71%   -0.07%     
==========================================
  Files         171      171              
  Lines        5241     5241              
==========================================
- Hits         4496     4492       -4     
- Misses        745      749       +4     

Impacted Files	Coverage Δ
ext/src/http/client/curl/http_client_curl.cc	80.31% <0.00%> (-1.13%)	⬇️
sdk/src/trace/batch_span_processor.cc	90.70% <0.00%> (-0.77%)	⬇️

[ThomsonTan]

Could this break some older version of bazel?

[davidmandle]

Could this break some older version of bazel?

I don't know for sure, but I do know that it continues to build successfully with the Bazel version specified in .bazelversion (4.2.0), and that other large projects have already successfully undergone this migration (e.g. grpc: grpc/grpc#29842).

[davidmandle]

Let me know if there's any actions I can take to address concerns about Bazel backwards compatibility. For what its worth, the grpc library, which has undergone this migration, tests over its set of supported Bazel versions .

[lalitb]

I don’t see any issue if this migration enable supporting bazel v6.0.0, is also working with v4.2.0. As of now we haven’t documented minimal supported bazel version - perhaps we can start doing that once we bump up bazel version to 6.0.0.

Also not related to this PR, but we need to think about continuing g++4.8 support, as that support is restricted with lower version of gRPC and bazel.

Approving this, but need one more approval to merge, and may have to wait a bit during holiday season :). Thanks for the PR.

[owent]

LGTM

[owent]

It seems also need upgrade gtest to 1.11.0 or upper and upgrade gRPC to 1.49.0 or upper.
Or the dependencies still use @bazel_tools//platforms, which can not compile with latest bazel.

[lalitb]

It seems also need upgrade gtest to 1.11.0 or upper and upgrade gRPC to 1.49.0 or upper.

Oh didn't realize that. Thanks for pointing out. Is it better to upgrade gRPC now, or once we bump the bazel version?

[davidmandle]

Thanks @owent, I've upgraded gtest to 1.12.1 and gRPC to 1.49.2. Let me know if there's any other actions I should take.

[lalitb]

Thanks @owent, I've upgraded gtest to 1.12.1 and gRPC to 1.49.2. Let me know if there's any other actions I should take.

CMake is still using older versions of these libraries, and also third_part_releases file should have these updated versions.

[owent]

LGTM now.And the gRPC version in ci/setup_grpc.sh and ci/do_ci.sh can also be updated.

[davidmandle]

Thanks. I believe now I've updated the versions throughout.